Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/node12 + add device caps #48

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix/node12 + add device caps #48

wants to merge 9 commits into from

Conversation

sebakerckhof
Copy link

This adds device capability listings (useful to filter meta capture devices in debian 10 based systems)

  • fixes compilation for node 10+ (currently works on latest 12 release)

@sebakerckhof sebakerckhof mentioned this pull request Sep 4, 2019
Open
@Crisfole
Copy link

Crisfole commented Nov 1, 2019

This looks like a dead repo, but in case it's not: I can verify this fix successfully fixes the install process. Currently testing the actual camera component itself

@uullrich
Copy link

uullrich commented Jan 4, 2020

It works perfect! With this fix there are no more problems during the build process.

@theflyingape
Copy link

theflyingape commented Dec 19, 2022 •
edited
Loading

Looks like there's an issue now with Python 3.11: ValueError: invalid mode: 'rU' while trying to load binding.gyp
The U file mode was removed in Python 3.11 because it had no effect so the U can merely be removed.

File "node/v12.22.12/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 234, in LoadOneBuildFile
    build_file_contents = open(build_file_path, 'rU').read()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid mode: 'rU' while trying to load binding.gyp

Removing the U works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebakerckhof @Crisfole @uullrich @theflyingape @sigoden